Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make decrypt method read api_key and api_secret from secrets.json #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jan 8, 2018

  1. Make decrypt method read api_key and api_secret from secrets.json

    The decrypt method on the Bittrex class was not actually reading
    credentials from secrets.json. This commit adds that.
    
    Justification:
    I don't currently understand how the decrypt method is supposed
    to be used. The way I understand this and would personally use
    python-bittrex in production is as follows:
    
    1. I would first create a secrets.json file (using for example
    the static encrypt function or preferrably a dedicated secrets.json
    creator). This could be done anywhere, for example offline.
    2. I would then upload the secrets file to an Internet-connected
    machine such as a VPS server and start running a trading script
    that utilizes python-bittrex as a dependency.
    3. When starting up the trading script, the trading script utilizing
    python-bittrex would call the decrypt method, I would provide the password
    for decripting credentials from secrets.json and decrypt method then
    carries on and the trading script can continue doing its thing.
    4. Now if the machine that the trading script was on gets compromized,
    the api_key and api_secret are not leaked.
    
    In summary: this commit aims to make the above a reality.
    
    Suggested further improvements: standalone secrets.json generator
    jannecederberg committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    0413b04 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2018

  1. Configuration menu
    Copy the full SHA
    73485b1 View commit details
    Browse the repository at this point in the history