Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor glitch in markdown ast preview #65

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

In the Markdown editor, long values were overlapping with their corresponding keys. Added a generic fix to resolve this issue.

Before After
image image

Related Issues

Is there anything you'd like reviewers to focus on?

I have reviewed the changes myself, and I would request the reviewers to check for any corner cases to ensure that none of the existing styles or functionalities are not affected.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Oct 3, 2024
@amareshsm amareshsm marked this pull request as ready for review October 3, 2024 18:19
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for eslint-code-explorer ready!

Name Link
🔨 Latest commit 9892790
🔍 Latest deploy log https://app.netlify.com/sites/eslint-code-explorer/deploys/67004a0bbc130d00087346da
😎 Deploy Preview https://deploy-preview-65--eslint-code-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tightly packed areas when we have more than 3 keys we might actually want to add ellipsis to the text?

before overflow ellipsis after overflow ellipsis
Screenshot 2024-10-04 at 12 15 17 PM Screenshot 2024-10-04 at 12 14 51 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a minimum height and overflow scroll to avoid this issue.

@harish-sethuraman
Copy link
Member

can you resolve conflicts in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants