ICM42670: I2C Driver-NG #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tore-espressif
force-pushed
the
refactor/icm4267_i2c_ng
branch
from
37fc0ac
to
c983f4d
Compare
espzav
reviewed
Oct 14, 2024
There was a problem hiding this comment.
@tore-espressif Thank you for this PR. I tested it on ESP-BOX-3 and found some issues in test app.
| static void i2c_bus_init(void) | ||
| { | ||
| const i2c_master_bus_config_t bus_config = { | ||
| .i2c_port = I2C_MASTER_NUM, |
There was a problem hiding this comment.
missing:
.clk_source = I2C_CLK_SRC_DEFAULT,
| esp_err_t ret; | ||
|
|
||
| i2c_bus_init(); | ||
| ret = icm42670_create(I2C_MASTER_NUM, ICM42670_I2C_ADDRESS, &icm42670); |
There was a problem hiding this comment.
Suggested change
| ret = icm42670_create(I2C_MASTER_NUM, ICM42670_I2C_ADDRESS, &icm42670); | |
| ret = icm42670_create(i2c_handle, ICM42670_I2C_ADDRESS, &icm42670); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
Update ICM42670 driver to I2C driver-NG
Related