chore: audit for unverified 'implemented' feature_backlog rows - #605
Open
essentialbit wants to merge 4 commits into
Open
chore: audit for unverified 'implemented' feature_backlog rows#605essentialbit wants to merge 4 commits into
essentialbit wants to merge 4 commits into
Conversation
…og rows reconcile_feature_backlog.py backfills stale status when a linked GitHub issue closes; audit_stuck_in_progress.py covers orphaned in_progress rows. Neither catches a row already at status='implemented' (which bumps agent_track_record via mark_proposal_done()) whose linked issue is still open with no merged PR ever closing it -- the exact Gemini bogus-self-bump failure mode already documented in project memory (#231/id-14, id=19). Read-only: never writes to feature_backlog, never touches agent_track_record, never calls mark_proposal_done(). Reuses the same regex-verified closes/fixes/resolves #N PR-timeline check as audit_stuck_in_progress.py rather than a raw cross-reference (which false-positives on incidental mentions). Live-run against the real DB found 4 flagged rows, all proposed_by=claude with real (merely not-yet-merged) PRs -- no bogus bump present currently, confirming the check works without false-negatives on the known-good case.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconcile_feature_backlog.pybackfills stale status when a linked GitHub issue closes;audit_stuck_in_progress.py(chore: add read-only audit for stuck in_progress feature_backlog rows #555, open) covers orphanedin_progressrows. Neither catches a row already atstatus='implemented'(which bumpsagent_track_recordviamark_proposal_done()) whose linked issue is still open with no merged PR ever closing it -- the exact Gemini bogus-self-bump failure mode already documented in project memory (St. Louis Fed Financial Stress Index (STLFSI4) macro-strip badge #231/id-14, id=19).scripts/audit_implemented_claims.py: read-only, same class asaudit_stuck_in_progress.py/audit_duplicate_issues.py/audit_stale_branches.py. Flagsimplementedrows whose linked issue is open AND no merged PR closes it (regex-verified viacloses/fixes/resolves #N, not a raw timeline cross-reference -- that false-positives on incidental mentions, confirmed live against issue Macro regime detector: FRED API (CPI/PMI/unemployment/yield curve) classifying risk-on/risk-off and inflation/deflation #103 previously).feature_backlog, never touchesagent_track_record, never callsmark_proposal_done().Verification
Live-run against the real DB (read-only, no mutation): 26
implementedrows checked, 4 flagged (ids 41/61/63/64, allproposed_by=claude) -- each traces to a real, currently-open-but-unmerged PR (#526, #564), not a bogus bump. Confirms the check fires correctly without false-negatives on the known-good case. Documented a known shared limitation (comma-listCloses #560, #562, #563.bodies only regex-match the first number -- same gap already present inaudit_stuck_in_progress.py, not new).Test plan
PYTHONPATH=. venv/bin/python3 -m py_compile scripts/audit_implemented_claims.pyPYTHONPATH=. venv/bin/python3 -c "import scripts.audit_implemented_claims"import sanity checkdata/sentinel.db(read-only) -- output reviewed above🤖 Generated by FredAI's autonomous hourly sensor (
com.essentialbit.fredai.sensor)