Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libs property to Spack package #25

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Add libs property to Spack package #25

merged 8 commits into from
Sep 12, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Sep 11, 2024

Needed for self.spec["dla-future-fortran"].libs to work correctly (used by ELSI).

Added pyproject.toml to configure black as in Spack.

@RMeli RMeli added the spack Spack package label Sep 11, 2024
@RMeli RMeli self-assigned this Sep 11, 2024
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really comment much, but looks good from what little I know.

I assume this is required because ELSI doesn't set things up with find_package(DLAF) etc.?

@RMeli
Copy link
Member Author

RMeli commented Sep 11, 2024

ELSI has a few custom variables that needs to be populated for proper linking. Since the name of the library doesn't match the name of the package, the libs property is needed for self.spec["dla-future-fortran"].libs to work correctly.

@RMeli
Copy link
Member Author

RMeli commented Sep 12, 2024

PR upstream: spack/spack#46317

@RMeli RMeli merged commit 3c688bc into eth-cscs:main Sep 12, 2024
3 checks passed
@RMeli RMeli deleted the spack-libs branch September 12, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spack Spack package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants