Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug_bundler_addUserOperations #211

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drortirosh
Copy link
Contributor

add a bulk of user operations, assuming they are all valid, without running any validation.
To be used in reputation tests, where a large # of userops is needed in memory, and it is very time-consuming validating a large # of userops.
note: only validation (tracing) is disabled. in-memory opsSeen calculations should be processed normally.

drortirosh and others added 3 commits October 31, 2023 19:33
bypass allchecks.
debug_bundler_addUserOperations
add an array of UserOps directly in to the mempool, without any
validation or throttling.
Copy link
Contributor

@forshtat forshtat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drortirosh I think adding an entire RPC method for this may be excessive. What do you think about making the "skip validation" a flag in the regular "send operation" API? (See issue https://opengsn.atlassian.net/browse/AA-401)

How often would you need to submit multiple invalid UserOperations simultaneously during testing?

@drortirosh
Copy link
Contributor Author

How often would you need to submit multiple invalid UserOperations simultaneously during testing?

  1. when doing reputation tests (which are currently disabled), we need to submit a large # of userops into the mempool multiple times. previously, it took minutes to "load up" the in-memory mempool, so a helper callback seems right.
  2. we don't want it to be a flag to sendTransaction (or sendUserOperation), since it is a debug function that better live in the "debug" namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants