AA-453: Support EIP-7702 tuples in ERC-4337 bundlers #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
reviewed
Sep 22, 2024
| try { | ||
| const feeData = await this.provider.getFeeData() | ||
| // TODO: estimate is not enough. should trace with validation rules, to prevent on-chain revert. | ||
| const type = eip7702Tuples.length > 0 ? TX_TYPE_EIP_7702 : TX_TYPE_EIP_1559 | ||
| const tx = await this.entryPoint.populateTransaction.handleOps(userOps.map(packUserOp), beneficiary, { |
There was a problem hiding this comment.
this is where the tuples should be sent
There was a problem hiding this comment.
Please see the code now. You were looking at a partially checked in code.
forshtat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.