Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: Fix AtLeastAsSafe ; Geth Mempool Filter E2E Test #12823

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

axelKingsley
Copy link
Contributor

@axelKingsley axelKingsley commented Nov 5, 2024

Demonstrates that Mempool Filtering works as expected.

  • adds a config to SuperSystem containing MempoolFiltering boolean flag
  • flag is passed down to geth on SuperSystem startup
  • existing tests were expanded to use filtering, or to disable it to check for miner behavior.

In the process of writing this test, I discovered that AtLeastAsSafe wasn't fully implemented, so I fixed that here too.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.65%. Comparing base (94ab846) to head (8070f04).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12823      +/-   ##
===========================================
- Coverage    68.66%   66.65%   -2.02%     
===========================================
  Files           56       56              
  Lines         4666     4666              
===========================================
- Hits          3204     3110      -94     
- Misses        1280     1384     +104     
+ Partials       182      172      -10     
Flag Coverage Δ
cannon-go-tests-32 61.88% <ø> (-2.02%) ⬇️
cannon-go-tests-64 54.16% <ø> (-2.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we'll need to merge the op-geth PR first, and cut an RC, and pull that into go.mod, before merging this PR.

@axelKingsley
Copy link
Contributor Author

axelKingsley commented Nov 5, 2024

LGTM, but we'll need to merge the op-geth PR first, and cut an RC, and pull that into go.mod, before merging this PR.

done in latest

@axelKingsley axelKingsley changed the title interop: Geth Mempool Filter E2E Test interop: Fix AtLeastAsSafe ; Geth Mempool Filter E2E Test Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants