Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code coverage - stack too deep issues #12843

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

AmadiMichael
Copy link
Member

Fixes #11093

@AmadiMichael
Copy link
Member Author

Note: forge coverage works if lib-keccak merges this ethereum-optimism/lib-keccak#6 and we update the dependency

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.65%. Comparing base (bc9b6cd) to head (5ba910d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12843      +/-   ##
===========================================
- Coverage    68.66%   66.65%   -2.02%     
===========================================
  Files           56       56              
  Lines         4666     4666              
===========================================
- Hits          3204     3110      -94     
- Misses        1280     1384     +104     
+ Partials       182      172      -10     
Flag Coverage Δ
cannon-go-tests-32 61.88% <ø> (-2.02%) ⬇️
cannon-go-tests-64 54.16% <ø> (-2.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@AmadiMichael
Copy link
Member Author

Also, for forge coverage to work, we'll need to make test_callWithMinGas_noLeakageHigh_succeeds and test_callWithMinGas_noLeakageLow_succeeds to work for 2 gas values each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracker] EVM Engineering: solidity code coverage
1 participant