fix(init): reject negative shard indexes - #519
Open
zakazaka95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--shard_indexvalues before connecting to L1Why
--shard_indexis parsed as a signed 64-bit value, but initialization later converts each index touint64. A value such as-1could therefore wrap to18446744073709551615instead of being rejected as invalid input. Validating immediately also avoids unnecessary RPC and configuration work.The regression failed before the fix because initialization proceeded to the invalid RPC endpoint; after the fix it returns the exact non-negative validation error before any RPC work.
Testing
go build -v ./cmd/...go test -v ./... -tags cigo vet -tags=ci ./...gofmtandgit diff --check