Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable codecov #262

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Re-enable codecov #262

wants to merge 2 commits into from

Conversation

etr
Copy link
Owner

@etr etr commented Feb 26, 2022

Identify the Bug

Codecov succeeds the execution but fails to handle the coverage files once pushed.

Description of the Change

This seems due to the library building on a separate path. The default codecov script uses the project base root as a starting point so the relative paths don't work.

This change attempts to fix the issue by disabling the standard directory rewrite used by codecov.

Alternate Designs

We could just build in the same directory in a separate build for codecov.

Possible Drawbacks

None

Verification Process

Github actions will execute the codecov action as part of the build.

Release Notes

Re-Enable automated code coverage calculation.

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #262 (86ee105) into master (bd559af) will increase coverage by 64.06%.
The diff coverage is n/a.

❗ Current head 86ee105 differs from pull request most recent head 50cdfaf. Consider uploading reports for the commit 50cdfaf to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #262       +/-   ##
===========================================
+ Coverage        0   64.06%   +64.06%     
===========================================
  Files           0       64       +64     
  Lines           0     3281     +3281     
===========================================
+ Hits            0     2102     +2102     
- Misses          0     1179     +1179     
Impacted Files Coverage Δ
usr/include/c++/9/ext/new_allocator.h 93.75% <0.00%> (ø)
usr/include/c++/9/bits/stl_iterator_base_types.h 100.00% <0.00%> (ø)
usr/include/c++/9/new 66.66% <0.00%> (ø)
usr/include/c++/9/bits/stl_construct.h 100.00% <0.00%> (ø)
usr/include/c++/9/bits/regex_compiler.h 48.21% <0.00%> (ø)
usr/include/c++/9/bits/regex.h 83.15% <0.00%> (ø)
usr/include/c++/9/bits/regex_scanner.h 56.25% <0.00%> (ø)
usr/include/c++/9/bits/regex_executor.tcc 38.60% <0.00%> (ø)
usr/include/c++/9/initializer_list 100.00% <0.00%> (ø)
usr/include/c++/9/bits/stl_tree.h 80.13% <0.00%> (ø)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd559af...50cdfaf. Read the comment docs.

@etr etr marked this pull request as draft February 26, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant