Closes #268: Fix POST processing of final keys without values #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'MHD_destroy_post_processor' should be called before the request callback for ensuring the processing of final keys without terminated values.
JavierJF
force-pushed
the
fix_post_process
branch
from
a2dece8
to
c2f6d28
Compare
etr
reviewed
May 14, 2022
| @@ -662,6 +662,11 @@ MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct details | |||
| if (found) { | |||
| try { | |||
| if (hrm->is_allowed(method)) { | |||
| if (mr->pp != NULL) { | |||
There was a problem hiding this comment.
nit: can we use nullptr instead of NULL
etr
reviewed
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#268
Description of the Change
The change is simple, instead of calling 'MHD_destroy_post_processor' in the destructor after the request has been processed, it's called before calling the registered processing callback.
Alternate Designs
I haven't think in alternate designs. I chose to call 'MHD_destroy_post_processor' right before
mr->callbackbecause I think it's the only place requiring of the final post processing of the request. Thus, keeping the two operation close makes sense.Possible Drawbacks
If all the information is going to be used just by
mr->callback, can't think of any drawback.Verification Process
Sorry, internal testing, just testing over the endpoints in a third party application.
Release Notes