Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a get-method for the content of a string_response #320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hsiegmund
Copy link

Description of the Change

Added a getter for the content of a string_response.
Example usage: a custom logger that shall log the content.

Release Notes

Added a get-method for the content of a string_response.

@etr
Copy link
Owner

etr commented May 5, 2023

I am not against having a get_content (or something of the likes) as part of the http_response, possibly to benefit logging. In the current approach though, this covers only string_response and I am not sure why this variant of the http_response should have different treatment from the rest.

I would propose we build something that can be reuse across all types of responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants