add toString to return correct value for verification.raw.topic B…

…igNumber result returned by `web3` `1.0.0-beta.55` - [CORE-256]
evannetwork · Jul 12, 2019 · 063cb94 · 063cb94
1 parent 2c77b0f
commit 063cb94
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/VERSIONS.md b/VERSIONS.md
@@ -5,9 +5,15 @@
 ### Features
 
 ### Fixes
+- add `toString` to return correct value for `verification.raw.topic` BigNumber result returned by `web3` `1.0.0-beta.55` 
 
 ### Deprecations
 
+## Version 2.8.4
+### Fixes
+- add `toString` to return correct value for `verification.raw.topic` BigNumber result returned by `web3` `1.0.0-beta.55` 
+
+
 
 ## Version 2.8.3
 ### Fixes

diff --git a/package.json b/package.json
@@ -85,5 +85,5 @@
     "testunitcoverage": "env-cmd ./.env.local npm run build && nyc -r lcov -e .ts -x \"$TESTSPECS\" mocha --exit -r ts-node/register $TESTSPECS && nyc report --reporter=text-lcov | coveralls"
   },
   "types": "./dist/index.d.ts",
-  "version": "2.8.3"
+  "version": "2.8.4"
 }
diff --git a/src/verifications/verifications.ts b/src/verifications/verifications.ts
@@ -1220,7 +1220,7 @@ export class Verifications extends Logger {
         signature: (<any>verification).signature,
         status: verificationFlag,
         subject,
-        topic: verification.topic,
+        topic: verification.topic.toString(),
         uri: (<any>verification).uri,
         valid: await this.validateVerification(subject, verificationId, isIdentity),
       };
@@ -1556,7 +1556,7 @@ export class Verifications extends Logger {
     );
 
     const dataHash = this.options.nameResolver.soliditySha3(
-      subjectIdentity, verification.topic, verification.data).replace('0x', '');
+      subjectIdentity, verification.topic.toString(), verification.data).replace('0x', '');
     const recoveredAddress = this.options.executor.web3.eth.accounts.recover(
       dataHash, verification.signature);
     const issuerContract = this.options.contractLoader.loadContract(