Remove payload from create_new_keys custom function #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineetpant
requested review from
wulfraem,
Tschuck,
dimgord and
S3bb1
and removed request for
wulfraem and
Tschuck
wulfraem
suggested changes
Nov 29, 2023
builds/wasm/src/vade/vade-api-bbs.ts
Outdated
| @@ -128,32 +127,23 @@ class VadeApiBbs extends VadeApiShared { | |||
| /** | |||
| * creates a new keypair for BBS+ based proofs | |||
| * | |||
| * @param params.keyOwnerDid did that will receive new public key | |||
| * @param options.identity Substrate identity to use (e.g. did:evan:0x12345) | |||
| * @param options.signingKey key to request the signing endpoint with | |||
| */ | |||
| public async createBbsKeys( | |||
There was a problem hiding this comment.
Maybe we can put this in one line now. Sorry, cannot suggest this in here due to a deleted line in the area to suggest a change for. oO
public async createBbsKeys(options: VadeOptions): Promise<BbsKeys> {
Cargo.toml
Outdated
| branch = "experimental/develop-next" | ||
| branch = "feature/remove-payload-from-create-new-keys" |
There was a problem hiding this comment.
Now we should be able to use the previous branch again. ^^
S3bb1
approved these changes
Nov 29, 2023
wulfraem
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR removes payload param from
create_new_keysin cli and other places as payload is not required for the custom functionDetails
create_new_keys