-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Rollout and activate" action #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the "Licence" headers to the files where they are missing
status.setSuccess(false); | ||
LOG.error("Exception during page replication", ex); | ||
} | ||
status.setSuccess(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ Need to move this inside try
, or else the status success will be reset to "true" after set to "false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
The ability to rollout and publish selected page in one click has been implemented. By means of an additional parameter in the request - shouldActivate. The servlet understands whether the page should be activated or not. A new service has been added that, in a multi-threaded pool, calls page replication if necessary.