[ERM-13] Revert changes upon unsuccessfull rollout #26
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubou-masiuk
requested review from
smiakchilo,
SkoryUladzislau and
AlKaliada
smiakchilo
approved these changes
Oct 17, 2024
SkoryUladzislau
approved these changes
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When AEM attempts to make a rollout for pages that have an MSM conflict (e.g. a page with the same name exists in a livecopy) it tries to resolve this conflict by renaming one of the pages. sometimes this process fails, but rollout manager does not clean the uncommited changes. Usually it does not cause any problems, but if we use the same resource resolver to perform any other operations, the uncommited changes are then committed.
Related Issue
#24