Skip to content

Commit

Permalink
Merge pull request #313 from excid3/v2
Browse files Browse the repository at this point in the history
V2
  • Loading branch information
excid3 authored Jan 15, 2024
2 parents ffa31e7 + e80cb94 commit 797878f
Show file tree
Hide file tree
Showing 183 changed files with 2,749 additions and 4,178 deletions.
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
blank_issues_enabled: false
contact_links:
- name: Get Help
url: https://github.com/excid3/noticed/discussions/new?category=help
about: If you can't get something to work the way you expect, open a question in our discussion forums.
- name: Feature Request
url: https://github.com/excid3/noticed/discussions/new?category=ideas
about: 'Suggest any ideas you have using our discussion forums.'
- name: Bug Report
url: https://github.com/excid3/noticed/issues/new?body=%3C%21--%20Please%20provide%20all%20of%20the%20information%20requested%20below.%20We%27re%20a%20small%20team%20and%20without%20all%20of%20this%20information%20it%27s%20not%20possible%20for%20us%20to%20help%20and%20your%20bug%20report%20will%20be%20closed.%20--%3E%0A%0A%2A%2AWhat%20version%20of%20Noticed%20are%20you%20using%3F%2A%2A%0A%0AFor%20example%3A%20v2.0.4%0A%0A%2A%2AWhat%20version%20of%20Rails%20are%20you%20using%3F%2A%2A%0A%0AFor%20example%3A%20v7.1.1%0A%0A%2A%2ADescribe%20your%20issue%2A%2A%0A%0ADescribe%20the%20problem%20you%27re%20seeing%2C%20any%20important%20steps%20to%20reproduce%20and%20what%20behavior%20you%20expect%20instead.
about: If you've already asked for help with a problem and confirmed something is broken with Noticed itself, create a bug report.
43 changes: 11 additions & 32 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,22 @@ on:
push:
branches:
- main

jobs:
sqlite:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_5_2
- rails_6
- rails_6_1
- rails_7
- rails_7_1
- rails_main
exclude:
- ruby: '3.0'
gemfile: 'rails_5_2'
- ruby: '3.1'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_6'
gemfile: 'rails_main'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true
Expand Down Expand Up @@ -60,23 +53,16 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_5_2
- rails_6
- rails_6_1
- rails_7
- rails_7_1
- rails_main
exclude:
- ruby: '3.0'
gemfile: 'rails_5_2'
- ruby: '3.1'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_6'
gemfile: 'rails_main'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true
Expand Down Expand Up @@ -116,30 +102,23 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: ['2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile:
- rails_5_2
- rails_6
- rails_6_1
- rails_7
- rails_7_1
- rails_main
exclude:
- ruby: '3.0'
gemfile: 'rails_5_2'
- ruby: '3.1'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_5_2'
- ruby: '3.2'
gemfile: 'rails_6'
gemfile: 'rails_main'

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
BUNDLE_PATH_RELATIVE_TO_CWD: true

services:
postgres:
image: postgres:12
image: postgres:16
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: password
Expand Down
2 changes: 1 addition & 1 deletion .standard.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ruby_version: 2.7
ruby_version: 3.0
ignore:
- '**/*':
- Style/HashSyntax
8 changes: 0 additions & 8 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
appraise "rails-5-2" do
gem "rails", "~> 5.2.0"
end

appraise "rails-6" do
gem "rails", "~> 6.0.0"
end

appraise "rails-6-1" do
gem "rails", "~> 6.1.0"
end
Expand Down
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
### Unreleased

### 2.0.0

* [Breaking] Noticed now provides its own models for managing notifications. Migrate existing model(s) to use the new Noticed tables.

TODO - add migration example

* [Breaking] Noticed::NotificationChannel has been removed. Use an ActionCable channel in your application instead.
* [Breaking] Twilio has been renamed to `twilio_messaging` to provide support for other Twilio services in the future.
* [Breaking] Vonage / Nexmo has been renamed to `vonage_sms` to provide support for other Vonage services in the future.

```ruby
class NotificationChannel < ApplicationCable::Channel
def subscribed
stream_for current_user
end

def unsubscribed
stop_all_streams
end
end
```

* `Notifications` have now been renamed to `Notifiers` and now inherit from the
* Email delivery method now supports args
* Support html safe translations for Rails 7+

### 1.6.3
Expand Down
Loading

0 comments on commit 797878f

Please sign in to comment.