Skip to content

Commit

Permalink
[eas-cli] remove @expo/config-types dependency (#2528)
Browse files Browse the repository at this point in the history
<!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. -->
<!-- You can skip the changelog check by labeling the PR with "no changelog". -->

# Why

Rely on ExpoConfig type from the `@expo/config` package in all places for consistency

# How

Rely on ExpoConfig type from the `@expo/config` package in all places for consistency

# Test Plan

Tests
  • Loading branch information
szdziedzic authored Oct 17, 2024
1 parent 20b76f7 commit 2dbaed5
Show file tree
Hide file tree
Showing 15 changed files with 17 additions and 45 deletions.
1 change: 0 additions & 1 deletion packages/eas-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"@expo/code-signing-certificates": "0.0.5",
"@expo/config": "8.5.4",
"@expo/config-plugins": "7.8.4",
"@expo/config-types": "50.0.0",
"@expo/eas-build-job": "1.0.136",
"@expo/eas-json": "12.5.2",
"@expo/env": "^0.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/__tests__/commands/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { AppVersionSource, EasJson } from '@expo/eas-json';
import { Command, Config } from '@oclif/core';
import { vol } from 'memfs';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/build/runBuildAndSubmit.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { Env, Platform, Workflow } from '@expo/eas-build-job';
import {
AppVersionSource,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';

import ContextField, { ContextOptions } from './ContextField';
import { findProjectDirAndVerifyProjectSetupAsync } from './contextUtils/findProjectDirAndVerifyProjectSetupAsync';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { InvalidEasJsonError } from '@expo/eas-json/build/errors';

import ContextField, { ContextOptions } from './ContextField';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';

import ContextField, { ContextOptions } from './ContextField';
import { findProjectDirAndVerifyProjectSetupAsync } from './contextUtils/findProjectDirAndVerifyProjectSetupAsync';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { getProjectConfigDescription } from '@expo/config';
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig, getProjectConfigDescription } from '@expo/config';
import { Env } from '@expo/eas-build-job';
import chalk from 'chalk';

Expand Down
3 changes: 1 addition & 2 deletions packages/eas-cli/src/commands/project/init.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ConfigError, getProjectConfigDescription } from '@expo/config';
import { ExpoConfig } from '@expo/config-types';
import { ConfigError, ExpoConfig, getProjectConfigDescription } from '@expo/config';
import { Flags } from '@oclif/core';
import chalk from 'chalk';
import nullthrows from 'nullthrows';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/commands/project/onboarding.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { Platform } from '@expo/eas-build-job';
import { AppVersionSource, EasJson } from '@expo/eas-json';
import chalk from 'chalk';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/eas-update/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';

import { ExpoGraphqlClient } from '../commandUtils/context/contextUtils/createGraphqlClient';
import { Client } from '../vcs/vcs';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/metadata/download.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { SubmitProfile } from '@expo/eas-json';
import fs from 'fs-extra';
import path from 'path';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/metadata/upload.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { SubmitProfile } from '@expo/eas-json';

import { AppleData } from './apple/data';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/update/configure.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import { Env, Platform, Workflow } from '@expo/eas-build-job';
import { EasJsonAccessor } from '@expo/eas-json';
import chalk from 'chalk';
Expand Down
2 changes: 1 addition & 1 deletion packages/eas-cli/src/utils/expoCli.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExpoConfig } from '@expo/config-types';
import { ExpoConfig } from '@expo/config';
import spawnAsync from '@expo/spawn-async';
import chalk from 'chalk';
import { boolish } from 'getenv';
Expand Down
33 changes: 4 additions & 29 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2dbaed5

Please sign in to comment.