Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Use credentials types from eas-build-job where possible #2191

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sjchmiela
Copy link
Contributor

Why

I've noticed we have two very similar types in eas-build and eas-cli. The types in eas-cli are just intermediate — in the end, when we hand off the build request to www we change them into the eas-build ones.

Wouldn't it be nice if we used the target types from the beginning?

How

Removed TargetCredentials in favor of Ios.TargetCredentials. IosCredentials in favor of Ios.BuildCredentials. Basically, that's it!

Also made some minor change to credentialsJson/types so that less types are exported so we are forced to try to use the eas-build-job ones.

Test Plan

TODO

Copy link

linear bot commented Jan 19, 2024

Copy link

github-actions bot commented Jan 19, 2024

Size Change: -2.04 kB (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB -2.04 kB (0%)

compressed-size-action

@sjchmiela sjchmiela force-pushed the stanley/eng-10909-flag-to-skip-credentials-validation-step-in-eas-build branch from ef3448f to 0371cfa Compare January 19, 2024 21:08
@sjchmiela
Copy link
Contributor Author

/changelog-entry chore Migrate to using credentials types from eas-build-job where possible

@sjchmiela sjchmiela force-pushed the stanley/eng-10909-flag-to-skip-credentials-validation-step-in-eas-build branch from 2af0295 to 12d09ea Compare January 19, 2024 21:18
@sjchmiela sjchmiela force-pushed the stanley/eng-10909-flag-to-skip-credentials-validation-step-in-eas-build branch from 12d09ea to d8e8060 Compare January 19, 2024 21:23
@sjchmiela sjchmiela changed the title Use credentials types from eas-build-job where possible [eas-cli] Use credentials types from eas-build-job where possible Jan 19, 2024
@sjchmiela sjchmiela marked this pull request as ready for review January 19, 2024 21:24
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8ea0579) 54.10% compared to head (d8e8060) 54.10%.

Files Patch % Lines
packages/eas-cli/src/build/ios/prepareJob.ts 20.00% 4 Missing ⚠️
...s/eas-cli/src/credentials/credentialsJson/utils.ts 0.00% 1 Missing ⚠️
...-cli/src/credentials/ios/IosCredentialsProvider.ts 66.67% 1 Missing ⚠️
...ctions/SetUpBuildCredentialsFromCredentialsJson.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2191      +/-   ##
==========================================
+ Coverage   54.10%   54.10%   +0.01%     
==========================================
  Files         516      516              
  Lines       18795    18793       -2     
  Branches     3769     3769              
==========================================
  Hits        10167    10167              
+ Misses       8607     8605       -2     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable, although I would do some manual testing for different distribution types and local credentials before merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants