Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eas-cli): use built-in Node fetch instead of undici #2419

Draft
wants to merge 1 commit into
base: @bycedric/eas-cli/swap-node-fetch-for-undici
Choose a base branch
from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jun 10, 2024

Why

This is a follow-up PR of #2414, to try and fall-back to the built-in Node fetch support as much as possible. This is an attempt, as likely more things will pop up that require refactoring.

Unfortunately, we still require undici as advanced "non-spec" features are used, like import { ProxyAgent } from 'undici'. But, this tries to use all built-in features as much as possible.

How

Test Plan

See GitHub Actions, and manual testing (everything)

Copy link

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant