Implement env:init, env:load and env:unload commands #2504
+356
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
c012511
to
5e4f171
Compare
|
Size Change: +10.4 kB (+0.02%) Total Size: 51.8 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
==========================================
- Coverage 52.59% 52.28% -0.31%
==========================================
Files 548 551 +3
Lines 20409 20607 +198
Branches 4163 4198 +35
==========================================
+ Hits 10732 10772 +40
- Misses 8837 8985 +148
- Partials 840 850 +10 ☔ View full report in Codecov by Sentry. |
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
5e4f171
to
1ffba14
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envpush-command
branch
from
be58276
to
e021f93
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
2 times, most recently
from
e1229ba
to
580d36e
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envpush-command
branch
from
a229442
to
e17b83a
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
580d36e
to
e37124b
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envpush-command
branch
from
e17b83a
to
ed27075
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
e37124b
to
5a70a4d
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envpush-command
branch
from
ed27075
to
546e27b
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
5a70a4d
to
09f1e9e
Compare
Base automatically changed from
piotrekszeremeta/eng-11920-add-eas-envpush-command
to
main
August 26, 2024 09:46
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
09f1e9e
to
703ba1f
Compare
khamilowicz
force-pushed
the
piotrekszeremeta/eng-11920-add-eas-envinit
branch
from
703ba1f
to
dacdfdd
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
szdziedzic
requested changes
Sep 12, 2024
Comment on lines
+32
to
+34
| if (nonInteractive) { | ||
| throw new Error("Non-interactive mode is not supported for 'eas env:init'"); | ||
| } |
There was a problem hiding this comment.
I would just remove this flag from the command
Comment on lines
+19
to
+21
| static override flags = { | ||
| ...EASNonInteractiveFlag, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| static override flags = { | |
| ...EASNonInteractiveFlag, | |
| }; |
| Log.log('Skipping adding the direnv hook to the shell config'); | ||
| Log.log('You may need to add the direnv hook to your shell config manually.'); | ||
| Log.log('Learn more: https://direnv.net/docs/hook.html'); | ||
| return; |
There was a problem hiding this comment.
Suggested change
| return; | |
| throw new Error |
to make it exit with non-zero code in such case
Comment on lines
+68
to
+69
| Log.log('The direnv hook is already present in the shell config'); | ||
| return; |
There was a problem hiding this comment.
I would throw error here as well
Comment on lines
+75
to
+79
| } else { | ||
| Log.log("Unable to determine the user's shell"); | ||
| Log.log('You may need to add the direnv hook to your shell config manually.'); | ||
| Log.log('Learn more: https://direnv.net/docs/hook.html'); | ||
| } |
There was a problem hiding this comment.
I believe we also need to throw an error here
| throw new Error('Your Linux distribution is not supported by this script.'); | ||
| } | ||
| } else { | ||
| Log.log(`Your platform (${platform}) is not supported by this script.`); |
There was a problem hiding this comment.
Suggested change
| Log.log(`Your platform (${platform}) is not supported by this script.`); | |
| throw new Error(`Your platform (${platform}) is not supported by this script.`); |
Comment on lines
+66
to
+68
| .filter((variable: EnvironmentVariableFragment) => variable.value !== null) | ||
| .map((variable: EnvironmentVariableFragment) => { | ||
| return `${variable.name}=${variable.value}`; |
There was a problem hiding this comment.
Suggested change
| .filter((variable: EnvironmentVariableFragment) => variable.value !== null) | |
| .map((variable: EnvironmentVariableFragment) => { | |
| return `${variable.name}=${variable.value}`; | |
| .filter((variable => variable.value !== null) | |
| .map((variable) => { | |
| return `${variable.name}=${variable.value}`; |
| @@ -24,7 +24,7 @@ export default class EnvironmentValuePull extends EasCommand { | |||
| ...EASNonInteractiveFlag, | |||
| path: Flags.string({ | |||
| description: 'Path to the result `.env` file', | |||
| default: '.env.local', | |||
| default: '.env.eas.local', | |||
There was a problem hiding this comment.
TBH I would stick with .env.local as default, I believe that's what the average person expects, and .env.local works as well with Expo SDK by default but .env.eas.local doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Commands streamlining usage of environment variables
eas env:init- install direnv, set up .envrc file and .gitignoreeas env:load --environment production- pulls envvars from given environment and loads themeas env:unload- unloads envvarsTest Plan
Tested manually