-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env:pull accepts environment as an argument rather than a flag #2654
base: main
Are you sure you want to change the base?
env:pull accepts environment as an argument rather than a flag #2654
Conversation
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Subscribed to pull request
Generated by CodeMention |
Size Change: -5.3 kB (-0.01%) Total Size: 53 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
==========================================
- Coverage 53.01% 53.00% -0.00%
==========================================
Files 567 567
Lines 21647 21651 +4
Branches 4242 4243 +1
==========================================
+ Hits 11474 11475 +1
- Misses 10143 10146 +3
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, although I believe that Jon's intention here was to make the same change for every eas env:xyz
command
Why
ENG-13930: Allow passing environment without the flag
It is more intuitive to use this command like:
rather than:
Test Plan
Tested manually