Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env:pull accepts environment as an argument rather than a flag #2654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khamilowicz
Copy link
Contributor

Why

ENG-13930: Allow passing environment without the flag

It is more intuitive to use this command like:

eas env:pull production

rather than:

eas env:pull --environment production

Test Plan

Tested manually

Copy link

linear bot commented Oct 24, 2024

@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Oct 24, 2024
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela

Generated by CodeMention

Copy link

Size Change: -5.3 kB (-0.01%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -5.3 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.00%. Comparing base (a212662) to head (78dc6e4).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/pull.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
- Coverage   53.01%   53.00%   -0.00%     
==========================================
  Files         567      567              
  Lines       21647    21651       +4     
  Branches     4242     4243       +1     
==========================================
+ Hits        11474    11475       +1     
- Misses      10143    10146       +3     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, although I believe that Jon's intention here was to make the same change for every eas env:xyz command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants