Skip to content

Commit

Permalink
Revert "[ios] Fix hermes inspector exception is uncaught and crash th…
Browse files Browse the repository at this point in the history
…e app."

This reverts commit 2822a4a.
  • Loading branch information
Kudo authored and gabrieldonadel committed Jan 8, 2024
1 parent afbb86b commit 99d6929
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,6 @@ std::optional<UserCallbackException> runUserCallback(C &cb, A &&...arg) {
cb(std::forward<A>(arg)...);
} catch (const std::exception &e) {
return UserCallbackException(e);
} catch (const std::runtime_error &e) {
// NOTE(kudo): Adding this to catch Hermes inspector exceptions after SDK 49.
// I still not figure out why the std::runtime_error is not catched by the std::exception above.
return UserCallbackException(e);
}

return {};
Expand Down

0 comments on commit 99d6929

Please sign in to comment.