[ios] Fix hermes inspector exception is uncaught and crash the app.

close ENG-9172
expo · Mar 14, 2024 · 9a5e9c8 · 9a5e9c8
1 parent e8f22a7
commit 9a5e9c8
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/packages/react-native/ReactCommon/hermes/inspector/Inspector.h b/packages/react-native/ReactCommon/hermes/inspector/Inspector.h
@@ -372,6 +372,10 @@ std::optional<UserCallbackException> runUserCallback(C &cb, A &&...arg) {
     cb(std::forward<A>(arg)...);
   } catch (const std::exception &e) {
     return UserCallbackException(e);
+  } catch (const std::runtime_error &e) {
+    // NOTE(kudo): Adding this to catch Hermes inspector exceptions after SDK 49.
+    // I still not figure out why the std::runtime_error is not catched by the std::exception above.
+    return UserCallbackException(e);
   }
 
   return {};