Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C89 comment for usage printf with rather old compiler that with -ansi compiler option #172

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

lygstate
Copy link

No description provided.

@lygstate lygstate changed the base branch from master to develop November 24, 2023 13:44
@eyalroz eyalroz force-pushed the develop branch 2 times, most recently from 9e247c1 to 835a48b Compare December 9, 2023 10:56
@eyalroz
Copy link
Owner

eyalroz commented Dec 15, 2023

This repository requires C99. If you believe this should change, please file and issue and make your case.

(( *)//.*\n)( *//.*\n)+
->
$2/**\n$0$2 */\n
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Copy link
Owner

@eyalroz eyalroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the compilation option change and the comments - are there more meaningful changes I may have missed?

src/printf/printf.c Show resolved Hide resolved
@eyalroz eyalroz merged commit 4a4435f into eyalroz:develop Jul 19, 2024
1 of 3 checks passed
@eyalroz
Copy link
Owner

eyalroz commented Jul 19, 2024

I'll just take this and work from there... but this doesn't compile with -ansi, still. So, consider this un-merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants