This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Added initial migration for the old old system. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a Member object not dissimmilar to the one in 3.4.5 (or w/e) however it has fewer fields: * want_spam is gone, it should apparently not be used. * year was replaced by join_date * undo_count has stopped being useful * balance should probably be a cached calculation rather than a field * gender was never used for anything useful * notes is replaced by note to follow django naming conventions * firstname/lastname are supplanted by name (simpler) New fields include pin and phone number, they are used for unique identification of members in situations like payment or sale. The two new fields also allow some more complex behaviour, e.g. removing formatting in phone number input or ensuring that pin is not saved as plain text but as a hash. Two validation functions were added, they do simple validation of pin and phone number. Phone number related computation could be moved out of Member since they could be useful to other systems.
Who turned off flycheck?!
|
To confirm, I should close this PR? |
|
No I did. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test pull request please ignore.