Skip to content

fix(kids): align MagicWords sentence blanks order in zh and ja level 2-1 (#1231) - #1245

Open
loulanyue wants to merge 1 commit into
f:mainfrom
loulanyue:fix/1231-fix-kids-level-2-1-magicwords-order
Open

fix(kids): align MagicWords sentence blanks order in zh and ja level 2-1 (#1231)#1245
loulanyue wants to merge 1 commit into
f:mainfrom
loulanyue:fix/1231-fix-kids-level-2-1-magicwords-order

Conversation

@loulanyue

@loulanyue loulanyue commented Aug 21, 2026

Copy link
Copy Markdown

Summary

Fixes #1231.

In src/content/kids/zh/2-1-missing-details.mdx and src/content/kids/ja/2-1-missing-details.mdx, the MagicWords sentence blanks order differed from the blanks definition (animal, place, activity), causing user inputs (e.g. animal) to be populated into the place slot in the rendered sentence.

Changes

  • Corrected sentence structures in Chinese (zh) and Japanese (ja) level 2-1-missing-details.mdx so that sentence blanks sequentially match [animal], [place], and [activity].

Summary

  • Corrected MagicWords sentence blank order in Chinese and Japanese Kids level 2-1 pages.
  • The order is now [animal], [place], and [activity].
  • Prevents inputs from populating the wrong slots.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d0faa3b-1397-489c-9797-09f9c2529f88

📥 Commits

Reviewing files that changed from the base of the PR and between 217c9b0 and 62d38b4.

📒 Files selected for processing (2)
  • src/content/kids/ja/2-1-missing-details.mdx
  • src/content/kids/zh/2-1-missing-details.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Japanese and Chinese MagicWords templates now describe an animal first, followed by its location and favorite activity.

Changes

Kids prompt order

Layer / File(s) Summary
Reorder localized MagicWords prompts
src/content/kids/ja/2-1-missing-details.mdx, src/content/kids/zh/2-1-missing-details.mdx
The Japanese and Chinese templates now use the animal, location, and activity sequence.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 62d38

This change only realigns sentence blanks with their defined order in the Chinese and Japanese level 2-1 content. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the MagicWords order fix for the Chinese and Japanese Kids level 2-1 pages.
Linked Issues check ✅ Passed The Chinese and Japanese templates now use the required [animal], [place], and [activity] order for issue [#1231].
Out of Scope Changes check ✅ Passed The changes are limited to the two language templates named in issue [#1231] and address the reported ordering problem.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report: Prompting for Kids中有一个问题

1 participant