Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade oc to 4.4 and use UBI8 base image #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arajkumar
Copy link
Member

Description

  • Upgrade Openshift cli to 4.4 to fix failure when running with OSD 4
  • Use UBI8 as base image
  • Move ServiceAccount and RoleBinding declarations into single template

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@centos-ci
Copy link
Collaborator

@arajkumar Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-worker-scaler:SNAPSHOT-PR-71

@centos-ci
Copy link
Collaborator

@arajkumar Your image is available in the registry: docker pull quay.io/openshiftio/rhel-fabric8-analytics-worker-scaler:SNAPSHOT-PR-71

@prashbnair
Copy link

Changes look fine to me but do we need this component to be deployed. My thinking is that it is not required as we are checking the status of the queue everyday and we can manually update the number of replicas. We are not a real time system where we have very strict SLA's for ingestion. @yzainee

@arajkumar
Copy link
Member Author

@prashbnair , Me too under same impression as you and in favour of scrapping this.

@yzainee-zz
Copy link
Member

@prashbnair As discussed earlier, this is not something that we need as of now. We can keep the repo and use it if needed. Currently, with the new ingestion process, the scaler will never be used

RUN pip3 install -r /tmp/requirements.txt
RUN pip3 install --no-cache-dir --no-cache --upgrade pip && pip install --no-cache-dir --no-cache --upgrade wheel
RUN pip3 install --no-cache-dir --no-cache -r /tmp/requirements.txt
RUN curl https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.4/linux/oc.tar.gz -o - | tar -zx -C /usr/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSD4 needs oc >= 4.x to interact with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants