Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output image info for LLDB debugging #350

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ttreyer
Copy link
Contributor

@ttreyer ttreyer commented Sep 18, 2023

Summary

When the GenJitDebug feature is enabled, output the relocation information of the JIT code to enable debugging with LLDB.

Test plan

$ lldb -- $OI/build/test/integration/integration_test_target oil folly_small_vector_int_default_overflow $OI/build/testing.oid.toml
(lldb) b oi::detail::OICompiler::applyRelocs
(lldb) e config.features[Feature::GenJitDebug] = true
(lldb) finish
...

@ttreyer ttreyer added core Core Framework (Process Control, Instruction Patching etc.) and removed cla signed labels Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #350 (0e38b97) into main (8dd1182) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   68.01%   67.98%   -0.03%     
==========================================
  Files         114      114              
  Lines       11138    11168      +30     
  Branches     1864     1869       +5     
==========================================
+ Hits         7575     7593      +18     
- Misses       2595     2602       +7     
- Partials      968      973       +5     
Files Changed Coverage Δ
oi/OICompiler.cpp 79.29% <62.50%> (-2.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed core Core Framework (Process Control, Instruction Patching etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants