Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert circleci workflow to github actions #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robandpdx
Copy link
Contributor

@robandpdx robandpdx commented Feb 12, 2024

Summary

This pull request converts the CircleCI workflows to GitHub actions workflows.
Notes

When trying to install the dependencies for the build job, I see the following error:
Error

Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
libgoogle-glog-dev : Depends: libunwind-dev or
libunwind7-dev but it is not installable
E: Unable to correct problems, you have held broken packages.
Error: Process completed with exit code 100.

This error does not occur when running the build job inside the ubuntu:22.04 container image.

The test job fails with errors too large to list here. Here is a link to the logs of a recent workflow run.

The coverage job was not tested becuase it depends on the failing test job. There should be a repo secret called CODECOV_TOKEN defined.

https://fburl.com/workplace/f6mz6tmw

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7103680) 62.71% compared to head (653b6f8) 62.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   62.71%   62.71%           
=======================================
  Files         123      123           
  Lines       12100    12100           
  Branches     1971     1971           
=======================================
  Hits         7589     7589           
  Misses       3555     3555           
  Partials      956      956           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JakeHillion
Copy link
Contributor

JakeHillion commented Feb 13, 2024

Hi @robandpdx, thanks for starting this migration! A couple of questions:

  1. I approved the CI runs yesterday on this PR and the new build jobs have been queued for ~14 hours. What's going on here?
  2. Given you've detailed the build job as failing, this clearly doesn't have feature parity with our existing CircleCI config. What are the next steps to make this work?

Thanks!

@ajor
Copy link
Contributor

ajor commented Feb 13, 2024

It looks like the test failures are due to the missing dependencies from the build job. They're all failing with this message:

error while loading shared libraries: libunwind.so.8: cannot open shared object file: No such file or directory

@robandpdx
Copy link
Contributor Author

What are the next steps to make this work?

Someone with better knowledge of the project should probably take it from here. I'm happy to help also if someone can provide me some direction on how to resolve the errors.

@JakeHillion JakeHillion changed the title convert circleci workflow to github actions convert circleci lint job to github actions Feb 20, 2024
@JakeHillion JakeHillion changed the title convert circleci lint job to github actions convert circleci workflow to github actions Feb 20, 2024
@JakeHillion
Copy link
Contributor

Just made a total mess of this PR... That'll teach me for using a WIP Git client. Should be mostly back now except for messing up the formatting in the description.

I've wanted to make a change to the linting check for a while so I've done that with GitHub actions in #488 as it seems to work fine. I'm not sure how to debug the other workflows at the minute as it's not possible to get into a running machine like it was with CircleCI, but at least this is a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants