Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shed][async_compression] fix warning for read_buf #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dymart
Copy link

@dymart dymart commented Mar 2, 2022

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2022
Atry added a commit to Atry/rust-shed that referenced this pull request Sep 1, 2022
…g::glog (facebookexperimental#31)

Summary:
X-link: facebook/fb303#31

Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`.

This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`.

Differential Revision: D39220438

fbshipit-source-id: d269c8e50ed20541054ea706394450043f8181ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants