Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py sacrebleu dependency to be compatible with fairseq's #85

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

justinhaaheim
Copy link
Contributor

@justinhaaheim justinhaaheim commented Nov 9, 2023

When installing fairseq & simuleval in the same project they currently complain of conflicting dependencies, since fairseq depends on sacrebleu@master and sacrebleu just updated master from 2.3.1 to 2.3.2.

ERROR: Cannot install fairseq and fairseq==0.12.2 because these package versions have conflicting dependencies.

The conflict is caused by:
    fairseq 0.12.2 depends on sacrebleu 2.3.2 (from git+https://github.com/mjpost/sacrebleu.git@master)
    simuleval 1.1.0 depends on sacrebleu==2.3.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

This should allow them to both depend on 2.3.2.

When installing fairseq & simuleval in the same project they currently complain of conflicting dependencies, since fairseq depends on sacrebleu@master and sacrebleu just updated master from 2.3.1 to 2.3.2.

This should allow them to both depend on 2.3.2.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2023
@xutaima xutaima self-requested a review November 9, 2023 03:21
@xutaima
Copy link
Contributor

xutaima commented Nov 9, 2023

Hi @justinhaaheim, thanks for the updates! Just a syntax fix: >== to >=

@justinhaaheim justinhaaheim merged commit ba792cc into main Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants