Iterable Dataloader Improvements #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ibanesh
force-pushed
the
dataloader-improvements
branch
from
28ceb5e
to
fb1cd0c
Compare
kauterry
reviewed
Nov 20, 2023
| @@ -245,11 +244,12 @@ def __call__(self, system): | |||
| with open( | |||
| self.output / "instances.log", "a" | |||
| ) if self.output else contextlib.nullcontext() as file: | |||
| idx = 0 | |||
There was a problem hiding this comment.
The new cur_index variable, where is it initialized to 0?
There was a problem hiding this comment.
We are not initializing cur_index to 0 but to start_index - 1 - https://github.com/fairinternal/seamless_communication/pull/118/files#diff-a404c48b410fd80711d9ff8bf3f705a9ea2ac9d53f533492104245e715e3dc20R51
kauterry
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IterableDataloaderto keep track of the current iterating index.