Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC streaming eval cli integration #94

Merged
merged 4 commits into from
Nov 23, 2023
Merged

SC streaming eval cli integration #94

merged 4 commits into from
Nov 23, 2023

Conversation

ibanesh
Copy link
Contributor

@ibanesh ibanesh commented Nov 23, 2023

  • Some changes for better integration of streaming evaluate cli in seamless_communication repo.
  • Also making some changes so that the help menu of simuleval cli is not blocked by th multiple parse_known_args call

@ibanesh ibanesh requested a review from xutaima November 23, 2023 01:38
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2023
annasun28
annasun28 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@annasun28 annasun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm after fixing unit tests

simuleval/options.py Outdated
Comment on lines 159 to 160
if args.user_dir is not None:
import_user_module(args.user_dir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, why remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what's breaking the unit tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! Thanks Anna. Was removed by mistake.

@ibanesh ibanesh merged commit d03a917 into main Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annasun28 annasun28 annasun28 approved these changes

@xutaima xutaima Awaiting requested review from xutaima

@kauterry kauterry Awaiting requested review from kauterry

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibanesh @annasun28 @facebook-github-bot