README Update with && instead of & #266
Conversation
The current command cd segment-anything-2 & pip install -e . should use && instead of &. Using && ensures that the pip install command only runs if the cd command is successful. The & operator runs both commands in parallel, which could lead to issues if the directory change isn't completed before the installation starts. This change improves the reliability of the script by preventing potential errors from occurring if the cd command fails.
|
Hi @Averylamp! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
NIT:
The current command cd segment-anything-2 & pip install -e . should use && instead of &. Using && ensures that the pip install command only runs if the cd command is successful. The & operator runs both commands in parallel, which could lead to issues if the directory change isn't completed before the installation starts.
This change improves the reliability of the script by preventing potential errors from occurring if the cd command fails.