Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#209 Print Failed Early implementation 1.x version #210

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

#209 Print Failed Early implementation 1.x version #210

wants to merge 1 commit into from

Conversation

keljtanoski
Copy link
Contributor

image

#209 This is the MR for print-failed-early option

Will check how this can be achieved in the version 2.x

@keljtanoski
Copy link
Contributor Author

Note: I will probably need to update the tests for this one.

Jean85
Jean85 reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right course of action. You're duplicating the output of the FailurePrinter, wouldn't be better to simply change that and call the same code, just earlier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keljtanoski @Jean85