Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for using GCP Application Default Credentials #1

Closed
wants to merge 4 commits into from

Conversation

fahadshamiinsta
Copy link
Owner

Description

This change will help the repository GCS plugin connection to the GCP client using the Application Default Credentials.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@fahadshamiinsta fahadshamiinsta changed the base branch from main to 2.7 June 27, 2023 01:42
final GoogleCredentials credentials = SocketAccess.doPrivilegedIOException(() -> GoogleCredentials.getApplicationDefault());
storageOptionsBuilder.setCredentials(credentials);
} catch(IOException e) {
logger.error("Error while getting \"Application Default Credentials\"", e);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Desired] I think it would be better to keep the exception message format consistent with the rest of the plugin: Failed to retrieve application default credentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants