Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue32 #33

Merged
merged 11 commits into from
May 29, 2024
Merged

Issue32 #33

merged 11 commits into from
May 29, 2024

Conversation

codecodeio
Copy link
Contributor

@codecodeio codecodeio commented May 24, 2024

Fix #32

Test URLs:

Info

  1. Adds Nav block to category and article pages
  2. Removing the Breadcrumbs or Categories text from the Nav block on sharepoint removes it from the website.
  3. Breadcrumbs and Category Dropdown are added to category and article pages
  4. All category and article pages are re-uploaded and previewed.
  5. The h1 is the last breadcrumb.
  6. categories are dynamically fetched from the category index. https://main--best-cigars-guide--famous-smoke.hlx.page/best-cigars-guide/index/category-index.json
  7. The category dropdown should always select the category the page is associated to.
  8. The category dropdown should work with js disabled.
  9. The styles closely mirror the original.
  10. The breadcrumbs and category dropdown wrap nicely on mobile, similar to how they currently work.
  11. Any trailing slash added to a category link in Sharepoint should be stripped out to the link renders correctly without a trailing slash.

Copy link

aem-code-sync bot commented May 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 24, 2024

Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

The breadcrumbs and category dropdowns correctly display on category and article pages with the correct links (without trailing slashes) and article titles. The category dropdown has the existing category pre-selected. I tested the category dropdowns on Chrome desktop, Safari on iOS, and Android Chrome.

One of the requirements in Jira was that this dropdown work when JS is disabled, however I wasn't able to load any pages with JS disabled, it just displays a blank page.

Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All criteria listed in the description is met, except the dropdown working without js, but only a blank page loads with js disabled, so that is a different issue.

@bdeffleyfamous bdeffleyfamous merged commit b5e0177 into main May 29, 2024
2 checks passed
@codecodeio codecodeio deleted the issue32 branch June 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Out breadcrumbs and dropdown for category/article pages
3 participants