-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue32 #33
Issue32 #33
Conversation
…dd breadcrumbs based on the url. Category list placeholder.
…le breadcrumbs and category dropdown for desktop/mobile.
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
The breadcrumbs and category dropdowns correctly display on category and article pages with the correct links (without trailing slashes) and article titles. The category dropdown has the existing category pre-selected. I tested the category dropdowns on Chrome desktop, Safari on iOS, and Android Chrome.
One of the requirements in Jira was that this dropdown work when JS is disabled, however I wasn't able to load any pages with JS disabled, it just displays a blank page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All criteria listed in the description is met, except the dropdown working without js, but only a blank page loads with js disabled, so that is a different issue.
Fix #32
Test URLs:
Info