Update cmd.js #58
Open
Update cmd.js #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
requested changes
Sep 27, 2024
Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Signed-off-by: Eva <joshua3d.contact@protonmail.com>
Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Signed-off-by: Eva <joshua3d.contact@protonmail.com>
Co-authored-by: Frazer Smith <frazer.dev@icloud.com> Signed-off-by: Eva <joshua3d.contact@protonmail.com>
|
Can you avoid any formatting changes? We don't use semicolons in this org. Please restore all the spread operators too. |
|
CI is failing. |
- removed semicolons to be in line with organization style - added spread operator to initialization of args
Certainly; just pushed a commit. 👍 and I will address any continuing CI failures soon |
- removed double quotes - added newline at end of file
|
Will address these last CI issues this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
path.resolve()for consistent paths; defaults to the current directory (.) when no valid argument is provided.argsinitialization.These changes improve script reliability and readability. Let me know if you need any adjustments.
I ran my own tests but felt it was unnecessary to include them in the pr.
Signed-off-by: @qbytx / Eva O'Brien evaobrien.contact@gmail.com
Checklist
run
npm run testandnpm run benchmark// tests passed for cmd.js
tests and/or benchmarks are included
// no features added
documentation is changed or added
// documentation is unchanged
commit message and code follows the Developer's Certification of Origin
and the Code of conduct