Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple code change to eliminate deprecated warning (See issue #99) #100

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Simple code change to eliminate deprecated warning (See issue #99) #100

merged 3 commits into from
Jan 19, 2024

Conversation

driverjb
Copy link
Contributor

Checklist

  • run npm run test and npm run benchmark
    • npm run benchmark does not exist
  • tests and/or benchmarks are included
λ npm run test

> @fastify/accepts-serializer@5.2.0 test
> npm run test:unit && npm run test:typescript


> @fastify/accepts-serializer@5.2.0 test:unit
> tap

​ PASS ​ test/test.js 55 OK 227.309ms
​


  🌈 SUMMARY RESULTS 🌈

​
Suites:   ​1 passed​, ​1 of 1 completed​
Asserts:  ​​​55 passed​, ​of 55​
​Time:​   ​6s​
----------------------|---------|----------|---------|---------|-------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------------------|---------|----------|---------|---------|-------------------
All files             |     100 |      100 |     100 |     100 |
 SerializerManager.js |     100 |      100 |     100 |     100 |
 index.js             |     100 |      100 |     100 |     100 |
----------------------|---------|----------|---------|---------|-------------------

> @fastify/accepts-serializer@5.2.0 test:typescript
> tsd

Replaced reply.context with request.routeOptions.config as recommended in the deprcation warning.
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@fastify/accepts-serializer",
"version": "5.2.0",
"version": "5.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the version here.
It should be handled by the releaser.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to submit a new PR or can we change it here directly?

Copy link
Contributor Author

@driverjb driverjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified the version back to the original value of 5.2.0

package.json Outdated Show resolved Hide resolved
Signed-off-by: Joel Driver <driverjb09@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7a97512 into fastify:master Jan 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants