This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: http2 support #9
Draft
climba03003
wants to merge
3
commits into
master
Choose a base branch
from
http2-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Nov 7, 2022
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Uzlopak
reviewed
Nov 7, 2022
@@ -0,0 +1,18 @@ | |||
// TODO: remove after node@18 End-of-Life | |||
'use strict' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldnt it maybe faster if we do it like this?
'use strict'
const status = { ':status': '103' }
function writeEarlyHints (reply, headers) {
return new Promise(function (resolve) {
if (reply.raw.socket === null) {
resolve()
return
}
Object.assign(headers, status)
reply.raw.stream.additionalHeaders(headers)
resolve()
})
}
module.exports = writeEarlyHints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should resolve after the headers are added.
Not directly resolved.
Uzlopak
reviewed
Nov 7, 2022
|
||
function write (reply, headers) { | ||
let message = '' | ||
for (const key of Object.keys(headers)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can avoid the value variable.
for (const key of Object.keys(headers)) {
if (Array.isArray(headers[key])) {
message += `${key}: ${headers[key].join(', ')}${CRLF}`
} else {
message += `${key}: ${headers[key]}${CRLF}`
}
}
How is the performance of for-of-loops?
Uzlopak
reviewed
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Uzlopak Sorry for duplication, but it should be how I would like to implement the
http2
withnative solution
.It still missing
test
forhttp2
.Checklist
npm run test
andnpm run benchmark
and the Code of conduct