Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fast-glob #403

Closed
wants to merge 2 commits into from
Closed

use fast-glob #403

wants to merge 2 commits into from

Conversation

gurgunday
Copy link
Member

Ref: https://github.com/isaacs/node-glob#comparison-to-other-javascript-glob-implementations

If you are reasonably sure that the patterns you will encounter are relatively simple, and want the absolutely fastest glob matcher out there, use fast-glob.

Checklist

@jsumners
Copy link
Member

jsumners commented Sep 4, 2023

Given that this a module for use by a wide audience, how do you guarantee the caveat you mentioned about simple glob cases? Additionally, this is a cost paid at start up. Does it really need to be "fast" at the cost of accuracy?

@gurgunday
Copy link
Member Author

I see your point, but in this case the glob pattern is simple

They are also both very popular

For the start-up time, we could help things with some refactoring, but at the end of the day, I just thought the API of the package was more suitable as it doesn't need to be promisifed

I don't have a strong opinion, we can leave this PR and I'll try to do some more testing and refactoring 🙏

@Eomm
Copy link
Member

Eomm commented Sep 4, 2023

Does it really need to be "fast" at the cost of accuracy?

Yeah, I don't think it worth. Backend's first rule:

  • it must work and it must be solid

Backend's 2nd rule:

  • it must be fast

@gurgunday
Copy link
Member Author

These are valid concerns. Closed with comment!

@gurgunday gurgunday closed this Sep 4, 2023
@gurgunday gurgunday deleted the glob branch September 4, 2023 17:44
@gurgunday gurgunday restored the glob branch September 4, 2023 17:44
@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 4, 2023

@gurgunday

Could you have a look why glob is not upgrading?

@gurgunday gurgunday deleted the glob branch September 6, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants