Upgrade glob to v10 #404
Closed
Upgrade glob to v10 #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only 1 test is failing |
|
Windows is failing for now Edit: not sure how to fix it |
Uzlopak
reviewed
Sep 4, 2023
| @@ -345,7 +343,7 @@ async function fastifyStatic (fastify, opts) { | |||
| const winSeparatorRegex = new RegExp(`\\${path.win32.sep}`, 'g') | |||
|
|
|||
| for (const rootPath of Array.isArray(sendOptions.root) ? sendOptions.root : [sendOptions.root]) { | |||
| const files = await globPromise(path.join(rootPath, globPattern).replace(winSeparatorRegex, path.posix.sep), { nodir: true, dot: opts.serveDotFiles }) | |||
| const files = await glob(path.join(rootPath, globPattern).replace(winSeparatorRegex, path.posix.sep), { follow: true, nodir: true, dot: opts.serveDotFiles }) | |||
There was a problem hiding this comment.
check what happens here, when glob is fed with the windows related options
This reverts commit 5038801.
|
I ping @isaacs, maybe he has some hint on how to fix it. Maybe using posix: true? |
This reverts commit d406405.
|
Time to install windows. |
|
@gurgunday |
|
This isn't possible as glob dropped support for node 14 in v9.x and we're still supporting (and testing against) node 14 in the CI. :( |
|
node 14 tests pass so far and this has to be a semver major anyway. |
|
Yeah even after purging Windows from all my machines, it seems to still cause me trouble 🤠 Without a hint on why things aren't working, I can only keep commit-guessing 🤣 |
This reverts commit baf24ce.
|
I'll try again on a Windows machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct