Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump dependency send@3 #455

Merged
merged 6 commits into from
Jul 12, 2024
Merged

chore!: bump dependency send@3 #455

merged 6 commits into from
Jul 12, 2024

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Jul 12, 2024

Note that the current test fail is due to @fastify/compress
https://github.com/fastify/fastify-compress/blob/14b83fe235000ed2620d2387b02f84b4170f55fa/index.js#L568-L573

Depends on fastify/send#80
We should wait until the next release of both @fastify/send and @fastify/compress.

Checklist

@@ -471,7 +471,7 @@ t.test('dir list json format - extended info', t => {
t.equal(response.statusCode, 200)
const bodyObject = JSON.parse(body.toString())
t.equal(bodyObject.dirs[0].name, 'empty')
t.equal(typeof bodyObject.dirs[0].stats.atime, 'string')
t.equal(typeof bodyObject.dirs[0].stats.atimeMs, 'number')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is bug on Node.js side, JSON.stringify do not print atime directly.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI is green

@mcollina
Copy link
Member

Can you update the actions too? We don't support Node v18 anymore.

@climba03003
Copy link
Member Author

Depends on fastify/fastify-compress#300

@gurgunday
Copy link
Member

Coverage

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jsumners jsumners merged commit cd0eae2 into next Jul 12, 2024
11 checks passed
@jsumners jsumners deleted the upgrade-send branch July 12, 2024 10:27
jsumners added a commit that referenced this pull request Jul 12, 2024
* feat: preparation for fastify@5 (#444)

* Update for v5

* c8 ignore

* remove dep

* c8

---------

Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>

* update fastify deps

* chore!: bump dependency send@3 (#455)

* chore!: bump dependency send@3

* fixup

* fixup

* chore: use v5 workflow

* chore: bump dependency send@3.1.0

* fixup

* update plugin config

* fix deprecation warning

---------

Co-authored-by: Mohammed Bilal Shareef <bilalshareef.h@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Co-authored-by: KaKa <23028015+climba03003@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants