Add implementation of mTLS for dynamic backends #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🎁 prepare release 0.6.1 * Remove the unreleased header. * Bump the version numbers for the next release.
I was idly looking through the final steps and realized I needed to do something earlier; this just makes that much clearer.
JakeChampion
approved these changes
Aug 8, 2023
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
* Update typenames.witx with the new extensions. * Support mTLS for dynamic backends. * Add a test case for mTLS. * Require fastly 0.9.6, which has mTLS support for dynamic backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because rustls makes you commit to whether or not you're going to use client certificates pretty early, this requires a more invasive change in how Viceroy makes TLS connections than I'd hoped. The result does pass the existing test suite, and I have an additional test case for the mTLS work that's been integrated. It does require us to add a new root certificate to the party, just for testing, though.
I can add additional SSL (non-client-cert) test cases, too, if that would be valuable.