Use a ResourceLimiter for tracking allocations #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acfoltzer
reviewed
Aug 7, 2023
| impl wasmtime::ResourceLimiter for Limiter { | ||
| fn memory_growing( | ||
| &mut self, | ||
| current: usize, |
There was a problem hiding this comment.
Can we confirm that this starts at zero? In other words, is memory_growing called when the initial heap for an instance is set up?
There was a problem hiding this comment.
The interface for allocating new Memory structures in wasmtime is Memory::new_dynamic and Memory::new_static. Both dispatch to Memory::limit_new, which will call memory_growing with a current value of 0.
There was a problem hiding this comment.
Awesome, thank you for checking!
acfoltzer
approved these changes
Aug 7, 2023
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
Co-authored-by: Adam C. Foltzer <acfoltzer@acfoltzer.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of counting the number of pages present in the memory exported by a wasm module, count the memory allocation diffs over time using the
ResourceLimiterapi.This change helps set us up for component support, as there's no analogue of
get_memoryfor components.