Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests as components #396

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Run tests as components #396

merged 2 commits into from
Jul 2, 2024

Conversation

elliottt
Copy link
Contributor

@elliottt elliottt commented Jun 28, 2024

Update tests to run as both core-wasm modules and components. This also includes a number of fixes to both the component adapter and component host side implementation.

@elliottt elliottt force-pushed the trevor/component-tests-1 branch 5 times, most recently from 679bc21 to 3c3d4a4 Compare June 28, 2024 20:38
@elliottt elliottt marked this pull request as ready for review June 28, 2024 23:00
@elliottt elliottt requested a review from acw June 28, 2024 23:27
Copy link
Contributor

@acw acw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see if the serial thing can work out, to help us understand what's breaking. But if it doesn't, then ping me and I'll approve without it.

cli/tests/integration/common.rs Outdated Show resolved Hide resolved
@elliottt elliottt requested a review from acw July 2, 2024 16:46
Copy link
Contributor

@acw acw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay testing!

@elliottt elliottt merged commit 2665239 into main Jul 2, 2024
7 checks passed
@elliottt elliottt deleted the trevor/component-tests-1 branch July 2, 2024 17:12
GeeWee pushed a commit to GeeWee/Viceroy that referenced this pull request Jul 25, 2024
Update tests to run as both core-wasm modules and components. This also includes a number of fixes to both the component adapter and component host side implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants