Support wat files when adapting core wasm
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/adapt-wat
branch
from
19660e7
to
542c902
Compare
elliottt
force-pushed
the
trevor/adapt-wat
branch
from
542c902
to
873809d
Compare
GeeWee
pushed a commit
to GeeWee/Viceroy
that referenced
this pull request
Jul 25, 2024
* Allow `wat` files to be adapted to components * Support `proc_exit` in guest wasm * Support `wat` files as arguments to `viceroy adapt` * Enable `wat` tests for components * Update the lock files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
.watfiles when adapting with either the--adaptflag, or theviceroy adaptcommand by first turning them into binary modules. Also, enable the tests that use wat files directly for components.