Implement the component-side hostcalls for KV Store #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computermouth
added a commit
that referenced
this pull request
Sep 27, 2024
* bring over changes from old branch * Fix the declaration for lookup-result methods in trappable_imports * start fleshing out builder api * complete port from the old branch * more kv store hostcalls, although linkage seems to be failing * open, list, insert, more or less working, need more work on error handling * fix up errors for inserts, compiles clean * finished error reporting for deletes * everything but ttl and regression tests * all tests pass, but infinite recursion when deleting in delete * fixed list ttl deletion, all tests pass * fix for old sdk on new hostcalls * clippy * add base64 to the cargo.lock * Added in the OOB check * write out metadata length, even on failure * cleanups as per @ulyssa * added unit tests for kv store hostcalls * Implement the component-side hostcalls for KV Store (#430) * match wit and component to trevor's working branch in xqd * lookup_wait impl for component * insert and delete * list impl * re-make adapter --------- Co-authored-by: Trevor Elliott <telliott@fastly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at implementing the component hostcalls in viceroy.
Keeping as draft until #427 is merged, as there's some component changes in that branch as well.